Hold for release 2.4 - Document impact of LP token freeze feature #3012
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisDawson
changed the title
oeggert
requested changes
Feb 24, 2025
Comment on lines
+112
to
+115
| If an LP token is associated with a liquidity pool that contains at least one frozen asset, the LP token is also frozen. This means: | ||
|
|
||
| 1. The holder can't send the frozen LP token to other accounts. | ||
| 2. The holder can receive frozen LP tokens, but can't send them out (similar to frozen trust lines). |
There was a problem hiding this comment.
I thought that a frozen asset in an AMM pool prevented anyone from depositing either asset to that pool? If that's the case, what other scenario could an account receive LP tokens besides a Payment or AMMDeposit transaction? Adding a suggestion based on the assumption you only have two ways of getting LP tokens.
Suggested change
| If an LP token is associated with a liquidity pool that contains at least one frozen asset, the LP token is also frozen. This means: | |
| 1. The holder can't send the frozen LP token to other accounts. | |
| 2. The holder can receive frozen LP tokens, but can't send them out (similar to frozen trust lines). | |
| If an LP token is associated with a liquidity pool that contains at least one frozen asset, the LP token is also frozen. This means: | |
| 1. Holders can't send frozen LP token to other accounts. | |
| 2. Accounts can't receive new LP tokens by attempting to deposit assets into the liquidity pool with a frozen asset. |
There was a problem hiding this comment.
holder can be frozen after they've deposited into the pool
|
|
||
| **Payments** | ||
|
|
||
| - A frozen account can no longer send LP tokens through direct payment. |
There was a problem hiding this comment.
Suggested change
| - A frozen account can no longer send LP tokens through direct payment. | |
| - An account can no longer send frozen LP tokens through direct payment. |
docs/concepts/tokens/decentralized-exchange/automated-market-makers.md
Outdated
Show resolved
Hide resolved
docs/concepts/tokens/decentralized-exchange/automated-market-makers.md
Outdated
Show resolved
Hide resolved
docs/concepts/tokens/decentralized-exchange/automated-market-makers.md
Outdated
Show resolved
Hide resolved
docs/concepts/tokens/decentralized-exchange/automated-market-makers.md
Outdated
Show resolved
Hide resolved
docs/concepts/tokens/decentralized-exchange/automated-market-makers.md
Outdated
Show resolved
Hide resolved
…akers.md Co-authored-by: oeggert <[email protected]>
…akers.md Co-authored-by: oeggert <[email protected]>
…akers.md Co-authored-by: oeggert <[email protected]>
…akers.md Co-authored-by: oeggert <[email protected]>
…akers.md Co-authored-by: oeggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.