Remove labels from filter button on toolbar#591
Closed
CatMe0w wants to merge 1 commit intoXcodesOrg:mainfrom
Closed
Remove labels from filter button on toolbar#591CatMe0w wants to merge 1 commit intoXcodesOrg:mainfrom
CatMe0w wants to merge 1 commit intoXcodesOrg:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is related to #498, #550, #572.
With the default width of the sidebar, clicking the filter button on the toolbar will make the button disappear from the sidebar area, ending up in the rightmost corner:


Technically, it works as intended, but it's very confusing from the perspective of users: it looks like the buttons just disappear. Dragging the sidebar to make it wider can reveal the buttons, but it's not intuitive. Actually, I got stuck here for a few days, trying to figure out where my beta versions went.
I think we might avoid the overflow entirely, and I tried some different approaches like using abbreviations instead of full text such as "Release only," but the overflow still happens and does not look good:

Finally, I found that completely removing the labels could be the most ideal solution. A filled, highlighted button with floating help text could be intuitive enough and won't break the consistency of the UI:


I hope this change improves the user experience and keeps the UI clean and functional.