This repository was archived by the owner on Nov 21, 2019. It is now read-only.
Fix issue with PDF attachments #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2015 15:45
There is an issue where the mime type of attachments it was always being set to application/x-www-form-urlencoded instead of what it should have been. See XeroAPI#43 (comment)
When setting an attachment to be viewable on-line requires ?IncludeOnline=true added to the URL. This fixes the first part of the problem with the URL not being formatted correctly. There is another problem I haven't been able to find yet with the signature not being correctly generated. See here for more info: XeroAPI#43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where the mime type of attachments was always being set to application/x-www-form-urlencoded instead of what it should have been. See #43 (comment)