Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add more demo gifs for readme.md #52

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

fliklab
Copy link
Contributor

@fliklab fliklab commented May 13, 2024

Description

  • Add more gifs and embed into readme.md
  • Replace main gif(the first one) into full-window shot

ETC

Checklist (Merge should only be performed once all of the following conditions are checked.)

  • I have completed the necessary tests and verified that the functionality works as intended.
  • I have written the code according to the code style guide.
  • I have confirmed that only the intended files and changes have been committed.
  • I have discussed these changes with my team members in advance, and all team members are aware of this PR.

@fliklab fliklab requested review from givvemee and glassk as code owners May 13, 2024 13:26
@fliklab fliklab self-assigned this May 13, 2024
Copy link
Member

@givvemee givvemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단하게 description 이라도 채워주심이 어떨까여. "제곧내" 도 괜찮습니다 ^^

Copy link
Contributor Author

@fliklab fliklab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단하게 description 이라도 채워주심이 어떨까여. "제곧내" 도 괜찮습니다 ^^

PR을 먼저 올리고 내용을 수정하는편인데 PR이 올라가면서 바로 리뷰 리퀘스트 되어서 빈 내용으로 리뷰를 받게 되는 경우가 종종 있는것 같네요

Copy link
Member

@glassk glassk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔한 이미지 감사합니다!

@fliklab fliklab merged commit 348a2f9 into dev May 13, 2024
2 checks passed
@fliklab fliklab deleted the docs/add-more-demo-gif branch May 13, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants