Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove close icon #46

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

Varsani2520
Copy link

@Varsani2520 Varsani2520 commented May 14, 2024

i removed the closed icon on the homepage dialog box model

i completed #38
close #38

@Yeasir0032 Yeasir0032 merged commit aa7ff4f into Yeasir0032:main May 14, 2024
@Yeasir0032 Yeasir0032 added enhancement New feature or request level1 gssoc labels May 14, 2024
@Varsani2520
Copy link
Author

Varsani2520 commented May 22, 2024

@Yeasir0032

if you merge my pr, then why i can;t find my name in contribution list ??

@Yeasir0032
Copy link
Owner

@Varsani2520
I don't know exactly the reason of this but it might be due to not referencing issue in the PR.

@Yeasir0032
Copy link
Owner

Try referencing the issue in this pr

@Varsani2520
Copy link
Author

@Yeasir0032 i update my pr with issue no please check and close #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

close icon not working
2 participants