Skip to content

Check netloc in urlparse result if path is empty #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check netloc in urlparse result if path is empty #803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion detect_secrets/core/usage/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,15 @@ def valid_looking_paths(path: str) -> str:
# May be local file.
# We do some initial pre-processing, but perform the file validation during the
# post-processing step.
components = parts.path.split('::')

# urllib can put results of urlparse into either path or netloc
# depending on the version, so check both
if parts.path:
components = parts.path.split('::')

elif parts.netloc:
components = parts.netloc.split('::')

if len(components) != 2:
raise argparse.ArgumentTypeError(
'Did not specify function name for imported file.',
Expand Down
Loading