Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEP-561 type-support marker #152

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

nemacysts
Copy link
Member

This will tell mypy and other tooling that this package is typed and that the types in this library (when present) should be used.

Once we start using a version with this in paasta, we'll unearth two failing type-checks:

paasta_tools/tron_tools.py:354: error: Argument "extra_volumes" to "get_spark_conf" of "SparkConfBuilder" has incompatible type "List[DockerVolume]"; expected "Optional[List[Mapping[str, str]]]"
paasta_tools/cli/cmds/spark_run.py:1236: error: Argument "extra_volumes" to "get_spark_conf" of "SparkConfBuilder" has incompatible type "List[DockerVolume]"; expected "Optional[List[Mapping[str, str]]]"

but:
a) these are easy to fix and,
b) it's a good thing that we're now using the right types :p

This will tell mypy and other tooling that this package is typed and
that the types in this library (when present) should be used.
@nemacysts nemacysts merged commit a8d7d6f into master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants