Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: add_custom_target does not require EXCLUDE_FROM_ALL #1453

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Feb 11, 2025

add_custom_target syntax does not support EXCLUDE_FROM_ALL, actually it is reveresed, you need to add ALL if you wish to add it to all target.

Without this change you would get

make nextpnr-all-bba -j9

[ 20%] Generating chipdb-384.bba
[ 60%] Generating chipdb-1k.bba
[ 60%] Generating chipdb-8k.bba
[100%] Generating chipdb-u4k.bba
[100%] Generating chipdb-5k.bba
[100%] Built target nextpnr-ice40-bba
make[3]: EXCLUDE_FROM_ALL: No such file or directory
make[3]: *** [CMakeFiles/nextpnr-all-bba.dir/build.make:70: CMakeFiles/nextpnr-all-bba] Error 127
make[2]: *** [CMakeFiles/Makefile2:383: CMakeFiles/nextpnr-all-bba.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:390: CMakeFiles/nextpnr-all-bba.dir/rule] Error 2

@mmicko mmicko requested a review from whitequark February 11, 2025 09:45
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how I managed to not catch it...

@whitequark whitequark merged commit 6caa6e4 into master Feb 11, 2025
16 checks passed
@whitequark whitequark deleted the micko/fix_exclude_all branch February 11, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants