async2sync: inherit src attributes on new_q and new_d wires#5730
Open
abhinavputhran wants to merge 2 commits intoYosysHQ:mainfrom
Open
async2sync: inherit src attributes on new_q and new_d wires#5730abhinavputhran wants to merge 2 commits intoYosysHQ:mainfrom
abhinavputhran wants to merge 2 commits intoYosysHQ:mainfrom
Conversation
…s. confirmed the tests fail without fix
Author
|
Added more comprehensive tests and confirmed they fail without fix |
widlarizer
approved these changes
Mar 11, 2026
Collaborator
widlarizer
left a comment
widlarizer
left a comment
There was a problem hiding this comment.
I forgot to link the original discussion to the issue. In the original discussion, I mentioned I'll have to fix this in a more sustainable way, but this is a valid interim solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5674
async2sync created wires new_q and new_d without src attributes, making them hard to trace in debug output. Fixed by inheriting the src attribute from the original flop cell on all newly created wires across all four conversion paths.
Added a test in tests/sat/async2sync.ys verifying the generated wires carry the correct src attribute.