feat: support property defaults with constant and enum refs (#336)#600
Open
ahochsteger wants to merge 1 commit intoYousefED:masterfrom
Open
feat: support property defaults with constant and enum refs (#336)#600ahochsteger wants to merge 1 commit intoYousefED:masterfrom
ahochsteger wants to merge 1 commit intoYousefED:masterfrom
Conversation
…#336) * add helper functions getDeclarationValue() and getInitializerValue() * make user symbols available to sandbox evaluation * simplify initializer logic (eliminate ifs)
Contributor
Author
|
@YousefED it would be great if you could give me some feedback, if I took the right way to implement this feature. AFAICS it should be a bit more generic, but I'm not sure, if there may be some edge cases that are still not handled properly and should generate a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please:
Readme.mdcloses #336