feat(linting): introduce jsonschema cli for linting and autofixing linting issues in schemas#625
Open
Karan-Palan wants to merge 5 commits intoYousefED:masterfrom
Open
feat(linting): introduce jsonschema cli for linting and autofixing linting issues in schemas#625Karan-Palan wants to merge 5 commits intoYousefED:masterfrom
Karan-Palan wants to merge 5 commits intoYousefED:masterfrom
Conversation
…nting issues in schemas Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
domoritz
requested changes
Sep 22, 2025
Collaborator
domoritz
left a comment
There was a problem hiding this comment.
Thanks for the pull request. I'm inclined not to merge this as one can easily call your cli afterwards. I don't yet see the benefit of integrating linting into this tool. By separating the tools, people can lint with the version they prefer.
I do like the idea of lining all generates examples in the tests, though. Can you change the pull request to only do that?
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Author
|
Apologies for the delay. I have updated the PR with fixed generated schemas. As of now, I have committed all the schemas that could be auto-fixed: Screencast.from.2025-10-13.10-01-25.mp4We are working on adding re-referencing functionality to the linter which would help autofix these rules. Once we have those features added, I will create a PR fixing other schemas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623
Introduced linting schemas and auto-fixing linting issues in the schemas by integrating the @sourcemeta/jsonschema cli
Changes made:
Checklist
Note:
For context, I, along with Juan (JSON Schema TSC member) defined linting rules for JSON Schema as a Part of a GSoC (Google Summer of code) project here - https://github.com/Karan-Palan/JSON-Schema-Linting, and implementing their auto-fixes here - https://github.com/sourcemeta/jsonschema/blob/main/docs/lint.markdown. This is what we have accomplished so far - https://github.com/Karan-Palan/GSoC-2025/blob/main/Final-report.md. We have recently added many rules
prefixing unknown keywords with x-which will be introduced in the newer JSON Schema drafts. We tested the linter on real world schemas and it was adopted by various projects like Vaccum, Manfred and many others. Many projects like ModelContextProtocol use this package for schema generation. One of their maintainers suggested to have the cli integrated in this package itself.Please:
Readme.md