refactor: use CSSStyleSheet object to adopt style sheet #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize inside shadow DOM dynamically
YuskaWu
force-pushed
the
refactor/dynamic-stylesheet
branch
from
4faaeac to
49b72ee
Compare
YuskaWu
force-pushed
the
main
branch
2 times, most recently
from
f6b8d99 to
b8d1cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CSSStyleSheet to change the custom property of size dynamically inside shadow DOM, so that we can prevent modifying inline style of github-corner element when the size attribute has changed.
(This PR can not merge since Safari does not support adoptedStyleSheets & CSSStyleSheet.replaceSync() API yet.)