Callbackfix #256
Open
Callbackfix #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhendryc
requested changes
Oct 17, 2025
| tree::Bonobo.BnBTree{<:FrankWolfeNode}; | ||
| callback=(args...; kwargs...) -> (), | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please remove Empty line
| branched_on=vidx, | ||
| branched_right=false, | ||
| distance_to_int=left_distance, | ||
| active_set_size=0, |
There was a problem hiding this comment.
Technically you know this size as it is the size of the Split active sets.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 86.23% 82.55% -3.69%
==========================================
Files 17 22 +5
Lines 1482 2814 +1332
==========================================
+ Hits 1278 2323 +1045
- Misses 204 491 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the s&a set info