Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/language UI update #797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

GaetanGrd
Copy link
Collaborator

Implementation

With the number of languages supported by BSM increasing all the time, a small redesign of the display to divide everything into two columns makes it all look better :D

Screenshots

before after
image image

How to Test

  • Clone my branch
  • use npm i then npm start
  • go settings

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

@GaetanGrd GaetanGrd requested a review from Zagrios February 8, 2025 18:16
Copy link

sonarqubecloud bot commented Feb 8, 2025

@GaetanGrd GaetanGrd self-assigned this Feb 8, 2025
@GaetanGrd
Copy link
Collaborator Author

I don't really know how to properly render my code, but if you have any suggestions, I'll take them.

Copy link
Owner

@Zagrios Zagrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaetanGrd Use CSS instead of JS for this. And if we want to have 3 columns someday, we'd have to redo everything.

Convert the root div to use grid instead of flex. Keep the direction property, remove splitColumns, and add a property like nbCol or nbSplit (since this property should work even with row direction) default to 1

You should be able to manage the direction with the CSS property grid-auto-flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants