rpc(getpeerinfo): Add inbound peers to method response

[oxarbitrage]

Motivation

We want to return outbound and inbound peer addresses in the getpeerinfo response. We currently return only outbound connections as these were the only ones we have access to by the address book. After #9201 was merged, we have inbound connections available in the MetaAddr struct so we can use that to return peers of both connection types in the RPC response.

Close #7893

Solution

• Use is_inbound() to know if a peer is inbound/outbound.
• Add a currently_live_peers() method to the AddressBookPeers trait so we can return peers that are likely connected to us now instead of the ones that were responding before.

Tests

Existing getpeerinfo tests were updated to reflect the change.

PR Author's Checklist

• The PR name will make sense to users.
• The PR provides a CHANGELOG summary.
• The solution is tested.
• The documentation is up to date.
• The PR has a priority label.

PR Reviewer's Checklist

• The PR Author's checklist is complete.
• The PR resolves the issue.

[arya2]

This looks like it should work, but it seems unnecessary to add another address book.

I made an alternative change in a9014f0 of #9201 if that looks acceptable.

Related: @mpguerra It would be nice to eventually refactor the address book into a service, it may be easier to do that ahead of adding fields to the getpeerinfo response.

[oxarbitrage]

This looks like it should work, but it seems unnecessary to add another address book.

I made an alternative change in a9014f0 of #9201 if that looks acceptable.

I don't think that is correct. For the getpeerinfo RPC method, when displaying an inbound connection it looks to me that the caller will expect to see the ephemeral port of the peer and not the default p2p port.

[oxarbitrage]

update recently_live_peers() to check that the last connection state is responded and that the peer has responded in the last HEARTBEAT_INTERVAL + 50ms. (recently_live_peers() is only used in getpeerinfo/getinfo, we should update that instead of adding a new method)

I agree that adding a new method is not really needed so that was removed as part of d90e639

While it is almost true that recently_live_peers() is only used in the getpeerinfo RPC, there is a marginal use of it in several metrics and tracing related code that i will prefer to leave as it is for now.

In regards to calculating if the peer is live by the use of HEARTBEAT_INTERVAL, it seems unnecessary as we can just use has_connection_recently_responded() which is what the now removed currently_live_peers() was doing. https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/meta_addr.rs#L499

So, what i did in d90e639 for the getpeerinfo RPC call was to use the recently_live_peers() method as it was before and then filter the results by has_connection_recently_responded() which should give us peers that are more likely to be connected now.

Let me know how do you see it. Thanks!