feat(state): Implements reconsider_block method #9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
previously approved these changes
Feb 17, 2025
arya2
reviewed
Feb 17, 2025
7 tasks
…m validate_and_commit if a candidate block's hash is in the map of invalidated blocks. Stores invalidated_blocks by height and clears when finalizing. Checks against non finalized tip hash to create a new chain if parnt_chain doesn't exist. Renames ReconsiderError variant NonPreviouslyInvalidatedBlock to MissingInvalidatedBlock.
|
This pull request has been removed from the queue for the following reason: Pull request #9260 has been dequeued, merge conditions unmatch:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
elijahhampton
commented
Feb 19, 2025
arya2
reviewed
Feb 20, 2025
…). Removes unused ReconsiderError variant. Opts to refuse block consideration if parent_chain does not exist. Adds db handle to reconsider_block function. Edits max blocks constant documentation
arya2
reviewed
Feb 21, 2025
Comment on lines
+366
to
+369
| if let Some(best_chain_root_height) = finalized_state.finalized_tip_height() { | ||
| self.invalidated_blocks | ||
| .retain(|height, _blocks| *height >= best_chain_root_height); | ||
| } |
There was a problem hiding this comment.
Optional: It would be better to check the finalized tip height before calling self.parent_chain() so it could insert a new chain instead.
parent_chain() will return None if the block's parent is missing in the non-finalized state, but if the block's parent is the finalized tip, normally Zebra inserts a new chain. It's not crucial for the reconsiderblock method, but it would be nice.
There was a problem hiding this comment.
I think I understand what you are saying now. If the parent is already finalized it would better to create a new chain of non finalized blocks and insert that. If not then we can make the call to parent_chain and proceed
…ized blocks only before checking parent_chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The changes create and test a reconsider_block method to later be integrated into the zebra RPC. This method reconsiders previously invalidated_blocks into a chain that exist in the chain_set. Closes #8842.
Specifications & References
NonFinalizedStatevia RPC methods #8634reconsider_block()method to theNonFinalizedStatefor validating/committing a previously invalidated block and its invalidated descendents #8842Solution
reconsider_blockmethod toNonFinalizedStatethat allows previously invalidated blocks to be reconsidered and re-inserted into the chain.Tests
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist