Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update the PR template #9277

Merged
merged 8 commits into from
Feb 21, 2025
Merged

chore: Update the PR template #9277

merged 8 commits into from
Feb 21, 2025

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 19, 2025

Motivation

  • We don't use the current PR template we intended to.
  • The C-trivial label is automatically assigned to PRs it doesn't belong to.

Solution

  • Simplify the PR template.
  • Remove the automatic assignment of the C-trivial label.
  • Use a new C-exclude-from-changelog label instead of the C-trivial one.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-exclude-from-changelog Category: The PR should be excluded from the changelog and release notes labels Feb 19, 2025
@upbqdn upbqdn self-assigned this Feb 19, 2025
@upbqdn upbqdn requested a review from a team as a code owner February 19, 2025 21:15
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team February 19, 2025 21:15
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 19, 2025
oxarbitrage
oxarbitrage previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

gustavovalverde
gustavovalverde previously approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@upbqdn upbqdn dismissed stale reviews from gustavovalverde and oxarbitrage via 0207605 February 21, 2025 14:47
@upbqdn upbqdn requested a review from mpguerra February 21, 2025 14:48
mergify bot added a commit that referenced this pull request Feb 21, 2025
@mergify
Merge of #9277
5aa7dde
@mergify mergify bot mentioned this pull request Feb 21, 2025
Closed
@mergify mergify bot merged commit 361fa65 into main Feb 21, 2025
97 checks passed
@mergify mergify bot deleted the update-pr-template branch February 21, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra approved these changes

@gustavovalverde gustavovalverde gustavovalverde left review comments

@oxarbitrage oxarbitrage oxarbitrage left review comments

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-exclude-from-changelog Category: The PR should be excluded from the changelog and release notes C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upbqdn @mpguerra @gustavovalverde @oxarbitrage