[install_commands] add option to inject install commands #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes just running apt-get install is not enouogh, so allow providing arbitrary installation commands Signed-off-by: akallabeth <[email protected]>
ZedThree
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Thanks @akallabeth, this is a nice addition! Just a couple of comments -- we need to handle quotes carefully, because there's a thousand ways yaml handles strings, and we can't rely on the user having quoted the command. And that's before it gets passed through a shell, which might do its own weird things
Co-authored-by: Peter Hill <[email protected]>
Co-authored-by: Peter Hill <[email protected]>
|
you're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes just running apt-get install is not enough, so allow providing arbitrary installation commands
[note] I am aware that the commands can (currently) just be added to
cmake_commandbut I do find that a bit ugly.