ZCS-10858 :- check for firewalld and setenforce for centos #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdeshmukh2209
changed the title
abhishekdeshmukh2209
requested review from
BhavinBathani,
dasiyogesh,
itsmeprashant,
Prashantsurana,
preshitaagrawal,
thefoolwhocodes,
prashantajari and
umagmrit
itsmeprashant
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:-
The firewalld package was installed during the Zulip installation, so we should start the
fiewalld service after the installation.
Since we are trying to add the firewall rule when firewalld was in stopped mode, the installation failed at that time.
If the SeLinux already disabled, then we should skip the setenforce 0 command line.
Fix:-
Added check if firewalld exists
Added check for setenforce