Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rebalancing Diagram #200

Merged
merged 2 commits into from
May 20, 2024
Merged

Add Rebalancing Diagram #200

merged 2 commits into from
May 20, 2024

Conversation

ksedgwic
Copy link
Collaborator

@ksedgwic ksedgwic commented May 4, 2024 •
edited
Loading

It's helpful to have diagrams when thinking about how CLBOSS works. This PR adds a "CLBOSS Rebalancing" diagram.

Questions:

  • Is the format of the diagrams acceptable? Do they looks ok for most folks?
  • Is creating a docs subdirectory the right thing?

@ksedgwic ksedgwic force-pushed the 2024-05-diagrams branch 4 times, most recently from b921351 to 70242ec Compare May 4, 2024 15:10
@ksedgwic ksedgwic mentioned this pull request May 4, 2024
Open
@ksedgwic ksedgwic force-pushed the 2024-05-diagrams branch 4 times, most recently from be0d945 to 70242ec Compare May 5, 2024 19:09
@ksedgwic ksedgwic marked this pull request as ready for review May 6, 2024 17:56
@ksedgwic ksedgwic changed the title Add Diagrams Add Rebalancing Diagram May 6, 2024
@ksedgwic ksedgwic force-pushed the 2024-05-diagrams branch from 70242ec to 12c5d00 Compare May 11, 2024 19:29
@ksedgwic ksedgwic force-pushed the 2024-05-diagrams branch 8 times, most recently from ba7ccac to 7e3fd9f Compare May 12, 2024 04:37
chrisguida
chrisguida approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Are you just using this little navigator in the bottom right in the markdown preview? Seems a bit clunky, but it works :)

image

@ksedgwic
Copy link
Collaborator Author

Yeah, but that interface sux.

https://mermaid-js.github.io/mermaid-live-editor/view#pako:eNq1WVtv4jgU_ivIo0q7Eq0oUCh5WGlaZna6KlXVdl9WkSrXOQELx87aTjsU-O_jXLgkJeQyqXggPpfPx-f4XAJLRIQDyEKtVuvkZEk51VZraSOXiTcyw1LbKFo74OKA6QfgDkiQIdVGwOY2Wq9b65MTm9vcQEwl9metp6tkqfSCQet6hjkH9p2GuleLMVUacwItlzJmfRm5L22lpZiD9aXX6yXPp2_U0TOr7_-MgG6MXRRrIU9P_1qFi1UOaCSd8K4xd6iDNdzwV1CaTkOA5wnmeAoR0KNglFCdFVelwCU0CZflhXj3UvhCQS7e0fMVgwPdqpXYIyUv5LEAf8OSg_Mdmo3wFvVTQnwYvX6MD-J9YIaIzASFxHyDcnsXK9zehbwdvS76A_wfGMfcA8gJaEmJWu2eKY6jmKLEWsoXXMG-Wm0TGr_GGfRPu8e3JjI-XqhGr_EGNJKOFsbH6ivHbPEeX7Es0THRMKX3KFDT6XAQvH42HILL8ja5ED5n8yCm1cNMrt89NuHiDJTKWlvyHubfk3vhBwxLqheN3pQd7KeEOAe-fpAzgFdMkPmTxGQew0TrAp0n6pl7H0pHT-edCeVB8VbGWOoaZ8QbbVZYU8GLTi08zxzoAQjQ11j9TmjqUlJTe0uKym6BfnhN3YA7H9J_n5iT_ofD95G775HU0XZOKw-QnK6S7tYjcUtZZZxWDNB4_8jC_2YDKdrgCau5ObTPIPL7DTdu42B8aVRISJoIk_2HW1HerkmhcUducaFJNooLzSYMCbHU6b56IuD6EbSmfKp-GFEWX9U0o4qn8mT2RpathRvzy-o3dl9KGDkWbwrkKv6KdOPHfVcnMjUGkaOWbnrNi_sbvabYF3WDnwv4L_eilfOxxWxYHvAKFmaaxtMbJTDGlC1qQzwYBeH9EIGsAlJnmCtGfTR9LFBJ0dzzVUyvf6fzxgeTPa_UgVQosiGrBhgNXvQdCueuCTYvQh6e17M4cUjKX-WT6h8c1eAqSVXWPsIA8-fAX5UxoBryDMj8GRMCvsYvDBraIRFspswdNqFsWP4OPDUT8BlhsdFe2__jTxutylhSvaPmo5QQPN4Pj3hxl0tVRoW6xT6TucXtpiDVd-yGJ7ScHaZgvBGEJSn93pkQjxh_IATpN6iN-19Gzbs_vVOB6w8I77PMHDoGYupoagZLC5TFSida_RqS3Sbf2ddY-hAO1lXcXeirLWrBCW1EjPVaBkSnCkkZmC0zelfa40HVSaEucEQbQ-iixfZVBLWRGYQ8TB1koWWIbyM9M-NA_Mt_8neAjWy-NqI40OJxwQmyjBOgjQI_tHRM8VRiL0385oQbIMvFTBmij_l_QmxlzBJZS_QTWaeds87leXd40R32R8PLYeeyc95GC2R1-72zy4vu6KJvPoNhpztYt9F7hNE5G513B_1hbzC46PaG_e6wjSDabxL_yWHC5NIpWv8CgAlXxQ

Trying to figure out how to launch that viewer ... gitlabs viewer might be better

@ksedgwic ksedgwic merged commit db55979 into ZmnSCPxj:master May 20, 2024
2 checks passed
@chrisguida
Copy link
Contributor

Awesome! Yeah the viewer you linked is better! 🚀🚀🚀

@ksedgwic ksedgwic mentioned this pull request Jun 17, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguida chrisguida chrisguida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksedgwic @chrisguida