Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid data processing with A curves, add some tests #28

Merged
merged 3 commits into from
Mar 23, 2024
Merged

fix: invalid data processing with A curves, add some tests #28

merged 3 commits into from
Mar 23, 2024

Conversation

sanyatuning
Copy link
Contributor

I found some bugs:

  • "since" parameter in the data request does not include "00:00" maybe the API changed a bit
  • the "A curve" algorithm assumes there is always a start sum value in the first row, but this is not always true

I also added some tests

@ZsBT ZsBT self-assigned this Mar 23, 2024
@ZsBT
Copy link
Owner

ZsBT commented Mar 23, 2024

Thanks a lot @sanyatuning for the fix and the code refactoring.

@ZsBT ZsBT merged commit 72560d1 into ZsBT:main Mar 23, 2024
3 checks passed
@ZsBT ZsBT self-requested a review March 23, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZsBT ZsBT Awaiting requested review from ZsBT

Assignees

@ZsBT ZsBT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanyatuning @ZsBT