fix: progress display race condition can result in LiveError #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daejunpark
reviewed
Jan 6, 2025
| @@ -753,6 +754,9 @@ def future_callback(future_model): | |||
|
|
|||
| # display assertion solving progress | |||
| if not args.no_status or args.early_exit: | |||
| # creating a new live display would fail if the previous one was still active | |||
| rich.get_console().clear_live() | |||
|
|
|||
There was a problem hiding this comment.
could you elaborate on the race condition scenarios? my goal was to ensure only a single Status instance exists at a time. is it not the case, or is the Live instance a different thing from Status?
There was a problem hiding this comment.
update from offline discussion: it's not super clear, but it might be related to the use of context manager within generator.
daejunpark
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.