fix(dory): blind jolt-dory zk commitments#1511
Merged
Merged
Conversation
Contributor
Benchmark comparison (crates) |
moodlezoup
reviewed
May 8, 2026
|
|
||
| impl crate::DoryScheme { | ||
| #[tracing::instrument(skip_all, name = "DoryScheme::stream_finish_zk")] | ||
| pub fn finish_zk( |
Collaborator
There was a problem hiding this comment.
It's a bit awkward that finish is a method defined on the StreamingCommitment trait, but the implementation is expected to differ depending on whether Dory is ZK or not. We should consider reworking the traits/types here to handle this more gracefully, but we can defer that to a follow-up
Contributor
|
Claude code review session started: https://claude.ai/code/session_012rW6emDAABLErCb58HhhQs |
moodlezoup
reviewed
May 11, 2026
moodlezoup
left a comment
Collaborator
There was a problem hiding this comment.
Dory ZK blinding looks correct; the streaming and combine paths thread commit_blind through coherently. A few notes on hot-path cost, the new trait default's hiding semantics, and a cross-mode hint footgun.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jolt-doryso Dory tier-2 commitments are blinded in ZK mode.DoryHint, including homomorphic hint combination and streaming ZK finish.Changes
ZkOpeningSchemewithcommit_zk.DoryScheme::commit_zkandDoryScheme::finish_zk.DoryHintand passes it intoopen_zk.Testing
cargo fmt -qgit diff --checkCARGO_NET_OFFLINE=true cargo metadata --no-deps --format-version=1 --quietcargo nextest run -p jolt-dory --cargo-quiet, but Cargo metadata tried to resolve the workspacesig-recoveryreth git dependency and stalled/fails offline because that dependency is not cached.cargo clippy --all --all-targetsstep for the same metadata/dependency-resolution issue; commit was completed with--no-verifyafter stopping the hung hook.