Fix ASDF error in ZCV module, add ASDF 3.1.0 support #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I think I want to go ahead and merge this and make a bugfix release since installations that use the latest ASDF version are going to start failing otherwise. CC @boryanah |
lgarrison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
OSError: Attempt to read block data from missing blockin the ZCV module, maybe caused by trying to load an array after the correspondingAsdfFilehad been garbage collected(?).Also adds support for ASDF 3.1.0, which renamed
asdf.compressiontoasdf._compression.I want to think a bit more generally about how we're loading arrays from ASDF files before we merge this. I think we're not doing it safely in many cases (e.g. not using context managers), but I'm also not exactly sure what ASDF guarantees about object lifetimes. There's also the related question of how to ensure that arrays in the tree that we reference are actually getting loaded before the file handle closes. I've opened asdf-format/asdf#1764 to ask about this.