Skip to content

Rename launchpad classes to include "_app_" in class name #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oblomov-dev merged 2 commits into from
Jul 10, 2026
Merged

Rename launchpad classes to include "_app_" in class name #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63b0e1
refactor: rename launchpad apps to z2ui5_cl_sample_app_000/001
claude Jul 10, 2026
9290b15
Merge branch 'standard' into claude/rename-sample-apps-kpvry0
oblomov-dev Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ There is **one launchpad per top-level package**, and they cross-link:

| App class | Lives in | Title | Mirrors | Button → other |
|--------------------------|----------|----------------------------------|-------------|----------------|
| `z2ui5_cl_sample_000` | `src/01` | `abap2UI5 - Samples` | `src/01/**` | "Extended Samples" → `sample_001` |
| `z2ui5_cl_sample_001` | `src/00` | `abap2UI5 - Samples (restricted)`| `src/00/**` | "Basic Samples" → `sample_000` |
| `z2ui5_cl_sample_app_000`| `src/01` | `abap2UI5 - Samples` | `src/01/**` | "Extended Samples" → `sample_app_001` |
| `z2ui5_cl_sample_app_001`| `src/00` | `abap2UI5 - Samples (restricted)`| `src/00/**` | "Basic Samples" → `sample_app_000` |

Both are identical in shape: a `get_catalog( )` method returning a flat table of
tiles, and a `view_display( )` that loops the catalog, emitting an H3 section
Expand All @@ -120,7 +120,7 @@ so `Binding`, `Binding I` … `Binding VIII` render as one block, then a gap, th
the `Event` block, and so on.

`z2ui5_cl_demo_app_000` is the old "classic" launchpad (now under `00/99`,
obsolete); `sample_000` links to it via a message strip. Do not extend it.
obsolete); `sample_app_000` links to it via a message strip. Do not extend it.

---

Expand Down Expand Up @@ -173,8 +173,8 @@ from the old catalog.

### Generation rules

1. **One catalog per area.** Apps in `src/01/**` belong in `sample_000`; apps in
`src/00/**` belong in `sample_001`. Never list an app in the wrong launchpad.
1. **One catalog per area.** Apps in `src/01/**` belong in `sample_app_000`; apps in
`src/00/**` belong in `sample_app_001`. Never list an app in the wrong launchpad.
2. **Each app appears exactly once**, and every demo app physically present in an
area is listed (no missing tiles) — **except hidden helper apps**: a class
whose `<DESCRIPT>` header is `ZZZ` (e.g. `ZZZ - called by SubApp I`) is only
Expand All @@ -196,7 +196,7 @@ from the old catalog.
6. **Moving a subpackage = moving its whole tile group** between the two
catalogs, inserted at the correct numeric slot (e.g. the uncategorized move
`src/01/07` → `src/00/11` lifted the entire `uncategorized` group out of
`sample_000` and into `sample_001`).
`sample_app_000` and into `sample_app_001`).
7. After every change, verify: `get_catalog( )` and the folder tree agree —
same apps, same group names (== CTEXT), same grouping, no app in the wrong
launchpad, none missing. The safest way to regenerate is to rebuild each
Expand Down
6 changes: 3 additions & 3 deletions scripts/generate-launchpad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Apps whose header is "ZZZ" are helper apps (called only by other apps)
* and are skipped.
* 3. Rewrite the result = VALUE #( ... ) block of get_catalog( ) in the
* launchpad app of each area (src/01 -> sample_000, src/00 -> sample_001):
* launchpad app of each area (src/01 -> sample_app_000, src/00 -> sample_app_001):
* - groups in folder-number order
* - tiles within a group sorted by header, then sub, then app
*
Expand All @@ -27,8 +27,8 @@ const SRC = path.join(__dirname, '..', 'src');

// area (top-level package under src) -> launchpad app file
const TARGETS = {
'01': path.join(SRC, '01', 'z2ui5_cl_sample_000.clas.abap'),
'00': path.join(SRC, '00', 'z2ui5_cl_sample_001.clas.abap'),
'01': path.join(SRC, '01', 'z2ui5_cl_sample_app_000.clas.abap'),
'00': path.join(SRC, '00', 'z2ui5_cl_sample_app_001.clas.abap'),
};

function walk(dir, out = []) {
Expand Down
6 changes: 3 additions & 3 deletions src/00/z2ui5_cl_sample_001.clas.abap → src/00/z2ui5_cl_sample_app_001.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CLASS z2ui5_cl_sample_001 DEFINITION PUBLIC.
CLASS z2ui5_cl_sample_app_001 DEFINITION PUBLIC.

PUBLIC SECTION.
INTERFACES z2ui5_if_app.
Expand Down Expand Up @@ -37,7 +37,7 @@ CLASS z2ui5_cl_sample_001 DEFINITION PUBLIC.
ENDCLASS.


CLASS z2ui5_cl_sample_001 IMPLEMENTATION.
CLASS z2ui5_cl_sample_app_001 IMPLEMENTATION.

METHOD z2ui5_if_app~main.

Expand Down Expand Up @@ -96,7 +96,7 @@ CLASS z2ui5_cl_sample_001 IMPLEMENTATION.
navbuttonpress = client->_event_nav_app_leave( )
shownavbutton = client->check_app_prev_stack( ) ).

DATA(url_standard) = |{ client->get( )-s_config-origin }{ client->get( )-s_config-pathname }?app_start=z2ui5_cl_sample_000|.
DATA(url_standard) = |{ client->get( )-s_config-origin }{ client->get( )-s_config-pathname }?app_start=z2ui5_cl_sample_app_000|.
page->header_content( )->button(
text = `Basic Samples`
icon = `sap-icon://action`
Expand Down
2 changes: 1 addition & 1 deletion src/00/z2ui5_cl_sample_001.clas.xml → src/00/z2ui5_cl_sample_app_001.clas.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>Z2UI5_CL_SAMPLE_001</CLSNAME>
<CLSNAME>Z2UI5_CL_SAMPLE_APP_001</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>abap2UI5 - Samples Overview (restricted)</DESCRIPT>
<STATE>1</STATE>
Expand Down
8 changes: 4 additions & 4 deletions src/01/z2ui5_cl_sample_000.clas.abap → src/01/z2ui5_cl_sample_app_000.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CLASS z2ui5_cl_sample_000 DEFINITION PUBLIC.
CLASS z2ui5_cl_sample_app_000 DEFINITION PUBLIC.

PUBLIC SECTION.
INTERFACES z2ui5_if_app.
Expand Down Expand Up @@ -42,7 +42,7 @@ CLASS z2ui5_cl_sample_000 DEFINITION PUBLIC.
ENDCLASS.


CLASS z2ui5_cl_sample_000 IMPLEMENTATION.
CLASS z2ui5_cl_sample_app_000 IMPLEMENTATION.

METHOD z2ui5_if_app~main.

Expand Down Expand Up @@ -101,8 +101,8 @@ CLASS z2ui5_cl_sample_000 IMPLEMENTATION.
navbuttonpress = client->_event_nav_app_leave( )
shownavbutton = client->check_app_prev_stack( ) ).

IF class_exists( `Z2UI5_CL_SAMPLE_001` ) = abap_true.
DATA(url_restricted) = |{ client->get( )-s_config-origin }{ client->get( )-s_config-pathname }?app_start=z2ui5_cl_sample_001|.
IF class_exists( `Z2UI5_CL_SAMPLE_APP_001` ) = abap_true.
DATA(url_restricted) = |{ client->get( )-s_config-origin }{ client->get( )-s_config-pathname }?app_start=z2ui5_cl_sample_app_001|.
page->header_content( )->button(
text = `Extended Samples`
icon = `sap-icon://action`
Expand Down
2 changes: 1 addition & 1 deletion src/01/z2ui5_cl_sample_000.clas.xml → src/01/z2ui5_cl_sample_app_000.clas.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOCLASS>
<CLSNAME>Z2UI5_CL_SAMPLE_000</CLSNAME>
<CLSNAME>Z2UI5_CL_SAMPLE_APP_000</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>abap2UI5 - Samples Overview (extension)</DESCRIPT>
<STATE>1</STATE>
Expand Down