ci: make ABAP_702 check the PR, lint generated branches, fix removed pop_bal usage#653
Merged
Merged
Conversation
- auto_cloud/auto_downport/check_downport: bump EOL node 16 to 20, matching the ABAP_* checks in this repo - auto_cloud/auto_downport: explicit contents: write plus a fixed concurrency group (cancel-in-progress: false) so concurrent runs cannot race on the force-pushed cloud/702 branches - PR checks (ABAP_*, check_downport): per-ref concurrency with cancel-in-progress so superseded runs stop early - check_downport: least-privilege contents: read Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
- read-only PR checks (ABAP_*, check_downport): checkout@v7 / setup-node@v6 tags - pushing workflows (auto_cloud, auto_downport, generate_overview_apps): SHA-pinned checkout v7.0.0 / setup-node v6.4.0 - quote node-version consistently as '20' - ABAP_702: drop the separate rm -rf src/00 step; the downport npm script already starts with it Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
All seven workflows run npm ci; cache the npm store via setup-node to avoid re-downloading dependencies on every run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
- ABAP_702 checked out the already-generated 702 branch (ref: 702), so every PR got the same result regardless of its content; it now checks out the PR merge ref and downports + lints that, like ABAP_STANDARD/ABAP_CLOUD do - check_downport is thereby redundant (same steps minus the lint) and is removed - auto_cloud/auto_downport force-pushed the generated cloud/702 branches unvalidated; both now lint with the matching config before committing - replace the unmaintained ad-m/github-push-action@v0.6.0 with a plain git push (checkout already persists the token) - auto_downport: drop the separate rm -rf src/00 (the downport script starts with it) - add dependabot for npm and github-actions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
…pp 154 Upstream abap2UI5 PR #2402 deleted z2ui5_cl_pop_bal; the BALLOG demo now opens the message table via z2ui5_cl_pop_messages (already used for the BAPIRET case in the same app). Verified with the standard config lint and the full downport + abap_702 lint chain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
- auto_cloud/auto_downport become thin callers of the new
auto_branch.yaml (inputs: branch, do_downport, lint_config); the
commit message on the generated branches now records the source
commit ('generate <branch> from <sha>')
- Node 20 maintenance ended in April 2026; the downport and all three
lint configs were verified under Node 22.22.2
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cross-repo CI/CD review. Two of the findings here are functional, one is urgent:
z2ui5_cl_pop_bal;z2ui5_cl_demo_app_154still called it, so theABAP_STANDARD/ABAP_CLOUDPR checks (which pull the framework dependency from upstream main) will fail on the next run without this fix. The BALLOG demo now usesz2ui5_cl_pop_messages, the same popup the app already uses for the BAPIRET case.ABAP_702checked out the already-generated702branch (ref: 702), so every PR got the same result regardless of its content. It now downports and lints the PR merge ref, likeABAP_STANDARD/ABAP_CLOUDdo.check_downport(same steps minus the lint) is thereby redundant and removed — if it is configured as a required status check, remove it from branch protection.auto_cloud/auto_downportforce-pushed the generatedcloud/702branches unvalidated; both now lint with the matching config before pushing, and both become thin callers of a new reusableauto_branch.yaml. The generated branches' commit messages now record the source commit.Plus hardening: Node 16 (EOL) → 22,
concurrency/permissionsblocks, npm caching, checkout/setup-node aligned with the abap2UI5 conventions (SHA pins for pushing workflows), the unmaintainedad-m/github-push-action@v0.6.0replaced with a plaingit push, dependabot added.Verification
Run locally under Node 22.22.2: standard lint (787 files, 0 issues) and the full downport +
abap_702.jsonclint chain (416 files, 0 issues), both including the app 154 fix. All workflow files parse as valid YAML.Merge order: merge after the abap2UI5 PR (abap2UI5/abap2UI5#2405) — no hard dependency, but the reusable-workflow conventions match that PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_014GerBGPsdTGNSbztfoU358
Generated by Claude Code