Skip to content

Commit

Permalink
Remove event queue prop
Browse files Browse the repository at this point in the history
  • Loading branch information
abhinavsingh committed Aug 11, 2024
1 parent 626a461 commit 54762f8
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions proxy/proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

from .core.ssh import SshTunnelListener, SshHttpProtocolHandler
from .core.work import ThreadlessPool
from .core.event import EventQueue, EventManager
from .core.event import EventManager
from .http.codes import httpStatusCodes
from .common.flag import FlagParser, flags
from .http.client import client
Expand Down Expand Up @@ -213,10 +213,6 @@ def __enter__(self) -> 'Proxy':
def __exit__(self, *args: Any) -> None:
self.shutdown()

@property
def event_queue(self) -> Optional[EventQueue]:
return self.event_manager.queue if self.event_manager is not None else None

def setup(self) -> None:
# TODO: Introduce cron feature
# https://github.com/abhinavsingh/proxy.py/discussions/808
Expand Down Expand Up @@ -264,12 +260,15 @@ def setup(self) -> None:
logger.info('Core Event enabled')
self.event_manager = EventManager()
self.event_manager.setup()
event_queue = (
self.event_manager.queue if self.event_manager is not None else None
)
# Setup remote executors only if
# --local-executor mode isn't enabled.
if self.remote_executors_enabled:
self.executors = ThreadlessPool(
flags=self.flags,
event_queue=self.event_queue,
event_queue=event_queue,
executor_klass=RemoteFdExecutor,
)
self.executors.setup()
Expand All @@ -280,7 +279,7 @@ def setup(self) -> None:
executor_queues=self.executors.work_queues if self.executors else [],
executor_pids=self.executors.work_pids if self.executors else [],
executor_locks=self.executors.work_locks if self.executors else [],
event_queue=self.event_queue,
event_queue=event_queue,
)
self.acceptors.setup()
# Start SSH tunnel acceptor if enabled
Expand Down Expand Up @@ -390,8 +389,11 @@ def sleep_loop(p: Optional[Proxy] = None) -> None:

def main(**opts: Any) -> None:
with Proxy(sys.argv[1:], **opts) as p:
if p.event_queue is not None and p.flags.enable_metrics:
with MetricsEventSubscriber(p.event_queue, p.flags.metrics_lock):
event_queue = event_queue = (
p.event_manager.queue if p.event_manager is not None else None
)
if event_queue is not None and p.flags.enable_metrics:
with MetricsEventSubscriber(event_queue, p.flags.metrics_lock):
sleep_loop(p)
else:
sleep_loop(p)
Expand Down

0 comments on commit 54762f8

Please sign in to comment.