Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Starting with metrics and prometheus #1414

Closed
wants to merge 2 commits into from

Conversation

magmax
Copy link

@magmax magmax commented Jun 1, 2024

Fixes #1320

WORK IN PROGRESS

It is not fully functional right now. First of all, it seems that my local environment doesn't accomplish all the requirements to run the pre-commit and pre-push hooks, but I wanted to share my current code with you.

The idea is:

  1. Plugins have the ability to send metrics, but they do not know anything about prometheus.
  2. Prometheus plugin receives the message and process it.

Problems:

  • prometheus_client has a singleton REGISTRY.
  • it is not possible to register two metrics with same name in the REGISTRY.
  • but I didn't want to use prometheus_client.REGISTRY on core.

@abhinavsingh abhinavsingh mentioned this pull request Aug 11, 2024
@abhinavsingh
Copy link
Owner

@magmax Thanks for the initial PR. I took a deep look and it required a different strategy to work w/ proxy.py. Please check PR #1447 which currently is in working state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Prometheus via plugin
2 participants