Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.cfg/extras_require configuration #1452

Merged
merged 3 commits into from
Aug 12, 2024
Merged

setup.cfg/extras_require configuration #1452

merged 3 commits into from
Aug 12, 2024

Conversation

abhinavsingh
Copy link
Owner

No description provided.

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (6602be3) to head (b08c179).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1452      +/-   ##
===========================================
- Coverage    83.97%   83.94%   -0.04%     
===========================================
  Files          180      180              
  Lines         8288     8288              
  Branches      1266     1266              
===========================================
- Hits          6960     6957       -3     
- Misses        1127     1130       +3     
  Partials       201      201              
Flag Coverage Δ
GHA 83.78% <ø> (-0.04%) ⬇️
Linux 83.42% <ø> (-0.04%) ⬇️
Python 3.10 84.44% <ø> (-0.04%) ⬇️
Python 3.11 83.62% <ø> (-0.10%) ⬇️
Python 3.12 83.68% <ø> (-0.04%) ⬇️
Python 3.6 84.39% <ø> (-0.03%) ⬇️
Python 3.7 84.39% <ø> (-0.03%) ⬇️
Python 3.8 84.45% <ø> (-0.04%) ⬇️
Python 3.9 84.51% <ø> (-0.04%) ⬇️
Windows 77.60% <ø> (-0.11%) ⬇️
macOS 83.78% <ø> (-0.04%) ⬇️
pytest 83.78% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavsingh abhinavsingh merged commit 74c42f6 into develop Aug 12, 2024
58 checks passed
@abhinavsingh abhinavsingh deleted the extras_require branch August 12, 2024 06:27
@webknjaz
Copy link
Contributor

@abhinavsingh that's probably because you dropped the lockfiles, including the one that pinned the build env, providing reproducible builds. Those were supposed to be updated periodically so that you'd see the breakage in corresponding bump PRs.

Abusing extras as environment definitions is discouraged as it's misuse of their actual purpose. Therefore I'm waiting for the dependency groups and lockfiles PEPs that would standardize the corresponding mechanisms correctly. I see you dropped reproducibility in favor of exposing pip install proxy.py[testing] to the end-users through packaging metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants