Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_CONNECT_TIMEOUT = 10.0 #1519

Merged
merged 2 commits into from
Feb 17, 2025
Merged

DEFAULT_CONNECT_TIMEOUT = 10.0 #1519

merged 2 commits into from
Feb 17, 2025

Conversation

abhinavsingh
Copy link
Owner

@abhinavsingh abhinavsingh commented Feb 17, 2025

Having a separate DEFAULT_CONNECT_TIMEOUT allows us to configure different values for connect and data timeout values. Currently, in this PR, this is hardcoded to 10.0 and cannot be overridden using flags currently.

Without this, overriding DEFAULT_TIMEOUT would automatically also apply during the connect phase leading into longer connect timeouts

@abhinavsingh abhinavsingh added the bot:chronographer:skip PR using this label is exempted from CHANGELOG management label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (d502349) to head (32d7d5c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1519   +/-   ##
========================================
  Coverage    84.66%   84.67%           
========================================
  Files          186      186           
  Lines         8420     8424    +4     
  Branches      1279     1279           
========================================
+ Hits          7129     7133    +4     
  Misses        1086     1086           
  Partials       205      205           
Flag Coverage Δ
GHA 84.52% <100.00%> (+<0.01%) ⬆️
Linux 84.16% <100.00%> (+<0.01%) ⬆️
Python 3.10 85.19% <100.00%> (+<0.01%) ⬆️
Python 3.11 84.41% <100.00%> (+<0.01%) ⬆️
Python 3.12 84.41% <100.00%> (+<0.01%) ⬆️
Python 3.6 85.15% <100.00%> (+<0.01%) ⬆️
Python 3.7 85.15% <100.00%> (+<0.01%) ⬆️
Python 3.8 85.18% <100.00%> (+<0.01%) ⬆️
Python 3.9 85.25% <100.00%> (+<0.01%) ⬆️
Windows 77.97% <100.00%> (+0.03%) ⬆️
macOS 84.48% <100.00%> (+<0.01%) ⬆️
pytest 84.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhinavsingh abhinavsingh merged commit dc952ab into develop Feb 17, 2025
46 of 47 checks passed
@abhinavsingh abhinavsingh deleted the connect-timeout branch February 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip PR using this label is exempted from CHANGELOG management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant