In Django >=4.2.14, the filepath for storing the files is not allowed t…#119
Open
chadgates wants to merge 2 commits intoabhishek-ram:masterfrom
Open
In Django >=4.2.14, the filepath for storing the files is not allowed t…#119chadgates wants to merge 2 commits intoabhishek-ram:masterfrom
chadgates wants to merge 2 commits intoabhishek-ram:masterfrom
Conversation
…o be an absolute path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o be an absolute path.
@abhishek-ram : we don't have this problem when DATA_DIR is not set. This is however a problem when DATA_DIR is set, even if it is set to MEDIA_ROOT (or vice versa). I therefore implemented an own storage config called "as2files".
In earlier version of Django it was not a problem when DATA_DIR was set to match MEDIA_ROOT as well, but that actually required this to be specifically set and was not transparent to the user.
Honestly, not sure if there is collateral - i have tested my scenarios and it works also be backward compatible. But maybe I am missing something.
More on the issue is here:
GHSA-9jmf-237g-qf46
and the allow_relative_path function in https://github.com/django/django/blame/main/django/core/files/utils.py
anyway, this is a suggestion