Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/Makefile.unix, external, apps: include entire archives in common binary #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

os/Makefile.unix, external, apps: include entire archives in common binary #10

wants to merge 1 commit into from

Conversation

abhishek-samsung
Copy link
Owner

common binary was earlier compiled by only including the undefined symbols from the app binaries. However, because of this, it is tightly coupled with apps. So, irrespective of undefined app symbols, include all the symbols from USERLIBS in common binary

@abhishek-samsung
os/Makefile.unix, external, apps: include entire archives in common b…
e6421b2 
…inary

common binary was earlier compiled by only including the undefined symbols
from the app binaries. However, because of this, it is tightly coupled with
apps. So, irrespective of undefined app symbols, include all the symbols from
USERLIBS in common binary
@abhishek-samsung
Copy link
Owner Author

binary size and heap usage with only undefined symbols from apps :

========== Size Verification of built Binaries ==========
Type        Binary Size     Partition Size      used(%)
 KERNEL      1,759,934 bytes    1,888,256 bytes      93.2%    PASS
 APP1              815 bytes      393,216 bytes      0.21%    PASS
 APP2            1,007 bytes    2,048,000 bytes      0.05%    PASS
 COMMON        101,955 bytes    2,875,392 bytes      3.55%    PASS
 BOOTPARAM       8,192 bytes        8,192 bytes     100.0%    PASS
=> Size verification SUCCESS!! The size of all binaries are OK.


****************************************************************
     Summary of Heap Usages (Size in Bytes)
****************************************************************
Total                           : 7086080 (100%)
  - Allocated (Current / Peak)  : 1415104 (19%) / 1450128 (20%)
  - Free (Current)              : 5670976 (80%)
  - Reserved                    : 32

binary size and heap usage with all the symbols :

========== Size Verification of built Binaries ==========
Type        Binary Size     Partition Size      used(%)
 KERNEL      1,759,934 bytes    1,888,256 bytes      93.2%    PASS
 APP1              815 bytes      393,216 bytes      0.21%    PASS
 APP2            1,007 bytes    2,048,000 bytes      0.05%    PASS
 COMMON        513,487 bytes    2,875,392 bytes     17.86%    PASS
 BOOTPARAM       8,192 bytes        8,192 bytes     100.0%    PASS


****************************************************************
     Summary of Heap Usages (Size in Bytes)
****************************************************************
Total                           : 7086080 (100%)
  - Allocated (Current / Peak)  : 1990304 (28%) / 2025280 (28%)
  - Free (Current)              : 5095776 (71%)
  - Reserved                    : 32

****************************************************************

r-prabu
r-prabu reviewed Mar 12, 2024
View reviewed changes
apps/platform/gnu/Make.defs
@@ -56,6 +56,8 @@ ifeq ($(CONFIG_HAVE_CXXINITIALIZE),y)
CSRCS += gnu_cxxinitialize.c
endif

CSRCS += gnu_unwind_find_exidx.c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be also included only for CXX?

build/configs/rtl8730e/loadable_apps/defconfig
CONFIG_FLASH_PART_SIZE="60,40,12,400,1844,4808,384,1844,4808,384,512,1280,8,"
CONFIG_FLASH_PART_TYPE="none,none,none,none,kernel,bin,bin,kernel,bin,bin,smartfs,ftl,bootparam,"
CONFIG_FLASH_PART_NAME="bl1,reserved,ftl,ss,kernel,app1,app2,kernel,app1,app2,userfs,reserved,bootparam,"
CONFIG_FLASH_PART_SIZE="60,40,12,400,1844,2808,384,2000,1844,2808,384,2000,512,1280,8,"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need changes in the partition?

samsung-singh
samsung-singh approved these changes Mar 12, 2024
View reviewed changes
Copy link

@samsung-singh samsung-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including entire archives in common binary, good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-prabu r-prabu r-prabu left review comments

@samsung-singh samsung-singh samsung-singh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishek-samsung @r-prabu @samsung-singh