sensors/mi48: add support for mi48 thermal camera #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Akkabathula <[email protected]>
Signed-off-by: Abhishek Akkabathula <[email protected]>
Taejun-Kwon
reviewed
Mar 22, 2023
| @@ -23,6 +23,10 @@ ifeq ($(CONFIG_SENSOR_PPD42NS),y) | |||
| CSRCS += ppd42ns.c | |||
| endif | |||
|
|
|||
| ifeq ($(CONFIG_MI48),y) | |||
| ****************************************************************************/ | ||
| #define DEVNAME_FORMAT "/dev/img%d" | ||
|
|
||
| #define GPIO_RESET PA_0 // will set it to the right pin after wards |
There was a problem hiding this comment.
so these pin numbers are only things related to rtl8721.
Then we can change init function as below, then we can merge this file with mi48.c
/** doxygen to explain each of params ...**/
int mi48_register(FAR const char *devname, FAR struct mi48_lower_s *lower, FAR struct i2c_dev_s *i2c, FAR struct spi_dev_s *spi, gpio_t pin1, gpio_t pin2) // but reset is necessary?
{
...
gpio_irq_init(&(g_rtl8721csm_dev.gpio_info.data_ready), pin1)
...
}
There was a problem hiding this comment.
gpio initializations, gpio control and attaching irq handlers for gpio interrupts are all board specific logic, so I wanted to keep it seperate from the sensor code, which is common for all boards.
| board_i2c_initialize(); | ||
| board_spi_initialize(); | ||
| // board_i2c_initialize(); | ||
| // board_spi_initialize(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.