Skip to content

Add test for false positive GPL3 license #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Add test for false positive GPL3 license #4106

merged 1 commit into from
Apr 23, 2025

Conversation

alok1304
Copy link
Contributor

@alok1304 alok1304 commented Jan 19, 2025 •
edited
Loading

Adding test for false positive GPL3 License.

Fixes #3932

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Alok Kumar [email protected]

@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch from 482a798 to 08f5769 Compare January 19, 2025 14:20
AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Apr 5, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alok1304, please see my review comments for your consideration

@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch 2 times, most recently from 37e942b to 5e53d12 Compare April 5, 2025 18:10
@alok1304
add test for false positive GPL3 license
5dd3418 
Reference: httpe://github.com/aboutcode-org/issues/3932
Signed-off-by: Alok Kumar <[email protected]>
@alok1304 alok1304 force-pushed the add-test-false-positive-gpl3 branch from 5e53d12 to 5dd3418 Compare April 11, 2025 18:17
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ff88b06 into aboutcode-org:develop Apr 23, 2025
38 checks passed
@AyanSinhaMahapatra
Copy link
Member

Thanks++ @alok1304 , merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra Awaiting requested review from AyanSinhaMahapatra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for False positive GPL3 license (not a bug)
2 participants
@alok1304 @AyanSinhaMahapatra