Skip to content

Updated models.py #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Dedsec0098
Copy link

Fixes #4092

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Added new document_url just like the given links for other package ecosystems

Signed-off-by: Shrish Mishra <[email protected]>
@Dedsec0098
Copy link
Author

@AyanSinhaMahapatra can you please help me solving these verifications?
I included signned-of-by in the commit message also

@AyanSinhaMahapatra
Copy link
Member

AyanSinhaMahapatra commented Apr 4, 2025

@Dedsec0098 Thanks for the PR. But this seems to me like an exact copy of #4099 to me, correct me if I'm wrong. The commits there are prior to your commits here.
Copying without proper credit/extra changes is not cool
Instead of opening a PR with the same changes why don't you try to collaborate on the same issue if you want to add something. There are also plenty other issues to pick.
Closing this, feel free to reopen if you disagree with anything/have your own changes.
Even if you build on top of someone else's PR, you should start your branch on top of theirs.
Also note that I've posted a review at #4099, this also applies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding new documentation_url to Package model
2 participants