Address review comments

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py

@@ -9,6 +9,7 @@
 
 import logging
 
+from aboutcode.pipeline import LoopProgress
 from django.db.models import Q
 
 from vulnerabilities.models import Advisory
@@ -27,7 +28,7 @@ def steps(cls):
 
     def fill_missing_summaries(self):
         """Find vulnerabilities without summaries and fill them using advisories with the same aliases."""
-        vulnerabilities_qs = Vulnerability.objects.filter(summary="").prefetch_related("aliases")
+        vulnerabilities_qs = Vulnerability.objects.filter(summary="")
         self.log(
             f"Processing {vulnerabilities_qs.count()} vulnerabilities without summaries",
             level=logging.INFO,
@@ -36,11 +37,13 @@ def fill_missing_summaries(self):
             created_by="nvd_importer", summary__isnull=False
         ).exclude(summary="")
         self.log(
-            f"Found {nvd_importer_advisories.count()} advisories from NVD importer",
+            f"Found {nvd_importer_advisories.count()} advisories with summaries from NVD importer",
             level=logging.INFO,
         )
 
-        for vulnerability in vulnerabilities_qs.paginated():
+        progress = LoopProgress(total_iterations=vulnerabilities_qs.count(), logger=self.log)
+
+        for vulnerability in progress.iter(vulnerabilities_qs.paginated()):
             aliases = vulnerability.aliases.values_list("alias", flat=True)
             # get alias that start with CVE- with filter
             alias = aliases.filter(alias__startswith="CVE-").first()
@@ -60,6 +63,7 @@ def fill_missing_summaries(self):
                 # Take the first matching advisory with a summary
                 # get the advisory that was collected the most recently
                 best_advisory = matching_advisories.order_by("-date_collected").first()
+                # Note: we filtered above to only get non-empty summaries
                 vulnerability.summary = best_advisory.summary
                 vulnerability.save()
                 self.log(