Skip to content

Migrate Advisory aliases field to M2M relationship #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 26, 2025
Merged

Migrate Advisory aliases field to M2M relationship #1784

merged 14 commits into from
Mar 26, 2025

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space force-pushed the convert-advisory-alias-to-concrete-relation branch 2 times, most recently from 3131477 to 2551014 Compare February 23, 2025 14:44
@keshav-space
Migrate Advisory aliases field to M2M relationship
4f6ffe8 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Make Alias vulnerability field optional
e9e0273 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Use advisory alias relation in pipelines and importer
0ba0593 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Update the test fixture to use the new alias field
6cc5bd3 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Remove unused include_metadata parameter
801f871 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Make unique_content_id required field
05ba61f 
- Also validate fields before saving

Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Update tests to support latest advisory model changes
996da13 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Provide content id when inserting advisory
04cab61 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space keshav-space force-pushed the convert-advisory-alias-to-concrete-relation branch from 2551014 to 04cab61 Compare March 25, 2025 11:41
@TG1999
Copy link
Contributor

TG1999 commented Mar 25, 2025

@keshav-space LGTM! few nits for your consideration. Also please run a few importers and improvers locally and provide logs for them here. Additionally report the status of migration/pipeline once tested locally.

@keshav-space
Ensure reference_id is always a string
6963158 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Add test for get_or_create_aliases
02d75b2 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Use iterator in vulnerability_status improver
16994eb 
Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Use unique_content_id for get_or_create Advisory
b3d5fc5 
- Since unique_content_id is a proxy for other fields using it is
  enough and sufficient.

Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Optimize alias migration using AdvisoryRelatedAlias
eeee06e 
- Use AdvisoryRelatedAlias to manage advisory alias relation

Signed-off-by: Keshav Priyadarshi <[email protected]>
@keshav-space
Merge remote-tracking branch 'origin/main' into convert-advisory-alia…
d86e3c2 
…s-to-concrete-relation
@keshav-space
Copy link
Member Author

@TG1999 here are the logs.
0090_migration.log
nginx_pipeline.log
curl-importer.log

@keshav-space keshav-space merged commit 89770c8 into main Mar 26, 2025
10 checks passed
@keshav-space keshav-space deleted the convert-advisory-alias-to-concrete-relation branch March 26, 2025 16:48
@keshav-space keshav-space self-assigned this Mar 27, 2025
@keshav-space keshav-space mentioned this pull request Mar 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 left review comments

Assignees

@keshav-space keshav-space

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VCIO-next: Migrate Advisory aliases from JSON field to M2M relationship
2 participants
@keshav-space @TG1999