-
Notifications
You must be signed in to change notification settings - Fork 19
GitHub Actions: Python 3.x #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
faa4607
GitHub Actions: Python 3.9 and 3.13
cclauss 2d73f57
3.8 is the oldest Python supported by validate-pyproject
cclauss b565c9b
Py3.12 is required
cclauss 4a6365e
Merge branch 'main' into patch-1
cclauss 64c3c55
Update .github/workflows/ci.yml
henryiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abravalheri, personally, I prefer listing this explicitly (
3.13), then updating it as soon as a beta comes out (leavingallow-prereleases: true). But that's also because I list the Python versions in trove classifiers, and once it passes for the first beta is the point I declare support for the new version. If you don't list versions you test on as classifiers, this seems fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @henryiii for assessing this.
I tend to simplify as much as I can the classifiers (I am not using them for the time being to record which versions the project is tested).
In the future we can change that if required.
Also open to have
allow-prereleases: true(as long as we don't require the pre-releases to pass). But we probably can have that in a separated PR if there is anyone in the community interested in that.For the time being the GHA CI is kept very lightweight the bulk of testing happens on cirrus (also open to review that if required).