NOISSUE - Use RabbitMQ as MQTT broker #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
rabbitmq
branch
3 times, most recently
from
49dfbb5 to
518b59e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
===========================================
- Coverage 42.01% 27.66% -14.35%
===========================================
Files 343 72 -271
Lines 47699 8504 -39195
===========================================
- Hits 20039 2353 -17686
+ Misses 25475 5979 -19496
+ Partials 2185 172 -2013 ☔ View full report in Codecov by Sentry. |
rodneyosodo
force-pushed
the
rabbitmq
branch
3 times, most recently
from
1fa3a37 to
e98d585
Compare
|
@rodneyosodo Please rebase. |
dborovcanin
requested changes
Feb 11, 2025
rodneyosodo
force-pushed
the
rabbitmq
branch
4 times, most recently
from
d12c628 to
dbf3819
Compare
rodneyosodo
force-pushed
the
rabbitmq
branch
3 times, most recently
from
eb10e13 to
3af54d6
Compare
|
@felixgateru Please review and test this one. |
felixgateru
previously approved these changes
Feb 20, 2025
rodneyosodo
force-pushed
the
rabbitmq
branch
from
3af54d6 to
ca57781
Compare
rodneyosodo
force-pushed
the
rabbitmq
branch
2 times, most recently
from
932412e to
0d94f14
Compare
dborovcanin
force-pushed
the
rabbitmq
branch
from
0d94f14 to
0a8c478
Compare
This reverts commit cff6e7f. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
This reverts commit 87db3e6. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Use rabbitMQ alpine rather than management-alpine since we are enabling that feature using config files Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
This reverts commit 9d8918b. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
rabbitmq
branch
from
0a8c478 to
a597025
Compare
The interceptor adds the correct credentials to the upstream MQTT broker Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
rabbitmq
branch
from
a597025 to
f16e7ab
Compare
dborovcanin
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: Add RabbitMQ as a MQTT broker.
What does this do?
The changes update the MQTT adapter and Docker configurations across the project. In the MQTT adapter, new configuration fields, a connection interceptor, and enhanced publisher/forwarder logic have been introduced, including authentication and QoS support. Docker-related files have been modified to integrate RabbitMQ as the MQTT broker, with updated environment variables, deployment documentation, and RabbitMQ-specific settings. Additional improvements include new tracing middleware for MQTT forwarding, updated dependency versions, and comprehensive tests for the MQTT pub/sub functionality using Docker.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes. I have tested MQTT pubsub, COAP pubsub and HTTP pub. WS will be fixed in another PR
Did you document any new/modified feature?
Notes