SMQ-2627 - Align PATs with new architecture #3295
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
- Coverage 76.52% 73.68% -2.85%
==========================================
Files 15 179 +164
Lines 1423 19701 +18278
==========================================
+ Hits 1089 14516 +13427
- Misses 246 4330 +4084
- Partials 88 855 +767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nyagamunene
force-pushed
the
SMQ-2627
branch
from
7aa84c3 to
8976860
Compare
| } | ||
|
|
||
| if strings.HasPrefix(token, patPrefix) { | ||
| tokenType := authn.TokenType(res.GetTokenType()) |
There was a problem hiding this comment.
This creates possible misconfiguration issue. I.e. what if token prefix here and tokenType returned from the service are not the same? While we are not able to validate token - we are able to parse it locally (even if only for prefix) and we can do this verification to prevent mismatch.
channels/middleware/authorization.go
Outdated
| } else { | ||
| req.Operation = auth.ListOp | ||
| } | ||
| req.Operation = auth.ChannelDisconnectClientOp |
There was a problem hiding this comment.
Let's stay consistent in naming, compare this to ClientConnectToChannelOp.
| UnshareOp | ||
| PublishOp | ||
| SubscribeOp | ||
| ClientCreateOp Operation = iota + 100 |
There was a problem hiding this comment.
Is it possible to reuse the existing service Operations ?
There was a problem hiding this comment.
we will have cyclic imports
nyagamunene
force-pushed
the
SMQ-2627
branch
from
d2f93f8 to
9632e74
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin
force-pushed
the
SMQ-2627
branch
from
81bc751 to
30bd274
Compare
3 participants
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes