sync fork #1
Merged
sync fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New issue template * Update PULL_REQUEST_TEMPLATE.md * Update ISSUE_TEMPLATE.md
https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html Both editors have the same signature `<editor> <projectPath> --line <number> <filePath>` to open file from the command line. It seems to work even if `<projectPath>` is omitted (commit 02f88ba). Tested on `Win10`+`PhpStorm2016` and `macOS 10.12`+`PhpStorm2017`.
* Adding link to tutorial on code splitting Link to tutorial on Code Splitting with React Router * Update README.md
* Update sw-precache-webpack-plugin to v0.11.3 * Pin the version
Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See https://webpack.js.org/guides/migrating/#complex-options
* add docs for setting up CircleCI for CRA * Reword
* Local testing with docker * Docs on e2e testing * `bash` callback after docker * Add a TL;DR in the CONTRIBUTING section * Local e2e testing with modified files * Remove the N.B. from the README * Fixed a fixme in e2e doc
* Auto-detect running editor on Windows for error overlay * Ignore process output if powershell call fails * Support Notepad++
* docs: added REACT_EDITOR to `Advanced Configuration` section * Update README.md * Update launchEditor.js
* Add service worker invalidation * Update valid service worker check only on local host
Due to many of the other examples in the README showing both `npm` and `yarn` commands. I have added an example of how to install a dependency using `yarn`.
* Update docs with WebSocket proxy information * Tweak wording
In the section about npm run build fails in troubleshooting added more info about memory usage of the build script and a link to a tutorial for adding more swap space as a viable solution.
I know this is a very minor thing, but correct grammar makes it easier to understand.
* Added instruction on how to install Prettier * Tweak style * Update README.md * Update README.md * Support JSX * Update README.md * Update README.md
* adding comment on windows support of nvm * adding tree structure for intial project output * applying feedback from this thread create-react-app/pull/1931
Adding the word "also" to "Can you also reproduce the problem with npm 4.x?" clarifies that contributors aren't _expected_ to use NPM v4, but we're interested in understanding which environments the reported issue affects.
* Put react-scripts in dependencies, not devDependencies * Sort dependencies on eject * Remove CI check
* Don't ask to install webpack for using Styleguidist * Update README.md
* Minor code style edits to user guide * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md
* Better React Native Web support * Adding better react-native-web support for jest testing
* Fix a command style in docs * Add a link to docker's docs
* Update Prettier to v1 * Update package.json
* Add changelog for 1.0.8 * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
* Add json and css to lint-staged in template README This changes the proposed way about using prettier inside the README.md, because prettier supports css since the 1.4.0 release and json since the 1.5.0 release. Was not sure if it was a good idea to add different regexes for json and css inside the README.md don't have a real opinion about it myself, could maybe easier for starters to do so if they wan't to add things like eslint or stylelint the the commit hooks. * Use capitalization for Javascript, CSS and JSON * Change 'Javascript to JavaScript'
* Test Node 8 on Travis We still test Node 7 on AppVeyor * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh * Update e2e-simple.sh * Update e2e-simple.sh * Update e2e-kitchensink.sh * Update e2e-installs.sh
* Add more info about apache client side routing After a revelation in #2593 (comment) * Update README.md
* Bootstrap with Yarn if we can * Update test scripts * Check OS and npm concurrency ability * Windows support * Update bootstrap.js * Install yarn before bootstrap
"Styleguidist combines of a style guide, ..." --> "Styleguidist combines a style guide, ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.