Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Layout Shift Fix) - Resolved Layout Issues on DarkMode Toggle Button and Full-Screen Modal #125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nitro56565
Copy link
Contributor

@nitro56565 nitro56565 commented Feb 18, 2025

Summary

This PR addresses layout shift issues affecting the DarkToggle Button and Full-Screen Modal, ensuring a smoother and more consistent UI experience.

Changes

  • Fixed unintended layout shift on Full screen modal while on start guide tour.
  • Adjusted positioning of the Darkmode button to prevent UI flickering and unnecessary clicks.

Screenshots or Video

Before

Screenshot From 2025-02-18 22-17-22
Screenshot From 2025-02-18 22-19-50

After

Screenshot From 2025-02-21 12-03-52
Screenshot From 2025-02-21 12-04-05
Screenshot From 2025-02-21 12-04-19

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: nitro56565 <[email protected]>
@nitro56565 nitro56565 requested a review from a team as a code owner February 18, 2025 17:26
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit b2330b2
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67b82273c85f3200086e9c54
😎 Deploy Preview https://deploy-preview-125--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the tutorial should actually be targeting the "Preview Output" header in that step instead, rather than the full screen toggle button.

@nitro56565
Copy link
Contributor Author

In the start tour, we generally cover the options, features, and usage of the playground. When David implemented the start tour, the full-screen modal was already a part of it. If I’m not mistaken, if you’re referring to including the entire header instead of just the full screen modal or dark mode toggle button, I can definitely work on clubbing it together.

@nitro56565
Copy link
Contributor Author

@DianaLease I have updated the layout by combining the preview output with the two feature buttons: Dark Mode and Full-Screen Modal. Additionally, I have added a step in the start tour for the Dark Mode button, as it was missing before.

@nitro56565 nitro56565 force-pushed the nitro56565/layout-and-UI-fix branch from 9ed9c56 to b2330b2 Compare February 21, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants