Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flag] Add flag editors table #9478

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[flag] Add flag editors table #9478

wants to merge 13 commits into from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Nov 18, 2024 •
edited
Loading

Brief summary of changes

  • Introduce a flag_editors table that tracks who has edited an instrument
  • Removes UserID from flag as it is replaced with the first entry of flag_editors
  • Removes User1 and User2 from conflicts_resolved as they are misleading columns, and also not useful now that UserID is gone from flag

Testing instructions (if applicable)

  1. Edit an instrument
  2. See that your UserID was added to the flag_editors table for that commentID
  3. Try starting a visit for a participant and see that the flag entry was added, and also to flag_editors

CCNA OVERRIDE PR

@skarya22 skarya22 self-assigned this Nov 19, 2024
@skarya22 skarya22 added the State: Needs work PR awaiting additional work by the author to proceed label Nov 19, 2024
@skarya22 skarya22 removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 19, 2024
@skarya22 skarya22 removed their assignment Nov 19, 2024
@maximemulder maximemulder added Project: CCNA Issue or PR related to the CCNA project Area: Instruments PR or issue related instruments Release: SQL patch PR that contains an SQL patch to apply and removed Priority: Projects labels Nov 29, 2024
shonibare
shonibare approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shonibare shonibare shonibare approved these changes

Assignees

@shonibare shonibare

Labels
Area: Instruments PR or issue related instruments Project: CCNA Issue or PR related to the CCNA project Release: SQL patch PR that contains an SQL patch to apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skarya22 @shonibare @maximemulder