Fix user singleton when an argument is passed. #9572
Conversation
User::singleton currently always returns the logged in user. If the $username argument is passed, it still returns the logged in user instead of the user requested. This updates the singleton so that it's possible to use it to get references to other users.
driusan
added
Category: Bug
|
@driusan I think this problem might be on 26 as well? can you fix it there if its the case please? it affects projects currently on 26 |
|
@ridz1208 I think the problem goes back to the beginning of time. What is the reasoning to put this on 26? I found this by trying to write new code. I don't think it affects any existing code since it's always called without an argument. |
|
@driusan I thought it broke recently, I tried using the singleton for a CBIG feature and realised it only ever returns the current user. I ended up using the factory directly. I figured it's a bugfix it could got to 26 but if its been like that ofrever its fine to just got o main |
|
I think that's the case for all existing code--anyone who tried using it realized it didn't work and used factory directly. That's why I sent this to main: as far as I can tell it doesn't fix any user-facing bugs since all current code has a workaround, but it makes it possible to use it in new code and is less surprising to anyone who tries to do it. |
User::singleton currently always returns the logged in user. If the $username argument is passed, it still returns the logged in user instead of the user requested.
This updates the singleton so that it's possible to use it to get references to other users.