Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepprep descriptor #297

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Deepprep descriptor #297

merged 3 commits into from
Feb 20, 2025

Conversation

natacha-beck
Copy link
Contributor

Basic descriptor for deepprep.

@prioux
Copy link
Member

prioux commented Feb 19, 2025

Looks good to me except you are missing the final newline character!

Copy link
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments, correct a typo. Would you like me to test it?

"ram": 12,
"walltime-estimate": 172000
},
"tags": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it an alternative to frmiPrep? I'd copy all tags from there

@@ -0,0 +1,116 @@
{
"name": "DeepPrep",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prioux not sure, do we have some convention to add a suffix SingleSubjects or BidsSubject to tool name or that practice is deprecated?

@prioux prioux merged commit 142dd83 into aces:master Feb 20, 2025
Copy link
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use "url" property to link the tool page, and "descriptor-url" for a descriptors page

"description": "An accelerated, scalable, and robust pipeline for neuroimaging preprocessing empowered by deep learning",
"descriptor-url": "https://deepprep.readthedocs.io/en/latest/",
"descriptor-url": "https://deepprep.readthedocs.io/en/24.1.2/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW
I think it is wrong url, descriptor-url is the url of the boutiques descriptor not tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants