Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding paid event routes #27

Closed
wants to merge 69 commits into from
Closed

Adding paid event routes #27

wants to merge 69 commits into from

Conversation

EthM370
Copy link

@EthM370 EthM370 commented Dec 3, 2024

Adding paid events plugin with get and single attribute update functionality.

@EthM370 EthM370 requested a review from tarashagarwal December 3, 2024 01:07
@EthM370 EthM370 self-assigned this Dec 3, 2024
@EthM370 EthM370 requested review from a team as code owners December 3, 2024 01:07
devksingh4
devksingh4 requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@devksingh4 devksingh4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please write unit tests along with the code
  2. we camel-case our routes so that its consistent - so for example /api/v1/paidEvents/merch - lets try to rewrite those names

Overall good start though!

devksingh4
devksingh4 reviewed Dec 3, 2024
View reviewed changes
devksingh4
devksingh4 reviewed Dec 3, 2024
View reviewed changes
EthM370
EthM370 commented Dec 9, 2024
View reviewed changes
Copy link
Author

@EthM370 EthM370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All pending integration and lint issue fixed, still need to write unit test

@tarashagarwal tarashagarwal changed the base branch from main to events_ticketing_unification December 21, 2024 00:10
devksingh4 and others added 17 commits January 5, 2025 14:05
@devksingh4
Move management UI into this repo (#25)
f8a107d 
* base setup for group relation creation

* add some stuff

* reorganize codebase to support adding UI

* move all the UI into one repo

* fix git

* test

* fix command

* fix

* fix

* fix deps

* update concurrency groups

* update names

* branch: main for cloudflare
@devksingh4
add git blame ignore revs
1b3067d
@devksingh4
add devcontainer configuration
c953122
@devksingh4
IAM panel to invite entra ID tenant users
44c74ee
@devksingh4
fix tests
5d4a90b
@devksingh4
fix bundle sizes
8db6e2e
@devksingh4
update container definition
97ed349
@devksingh4 @github-advanced-security
Enable exec group modification by IAM admins (#28)
435a789 
* add group modification route with protected groups support

* modify endpoint names; add listing group membership route

* fix response types

* basic unit tests

* test ui

* fix build dir

* enable better preview

* add panel

* Fix code scanning alert no. 8: Server-side request forgery

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@tarashagarwal @devksingh4
Handling Undefined process variable while running vite server (#29)
b47c64f 
* Handling Undefined process variable while running vite server

* Passing the env varibles in the vite config

* Sourcing ENV Variables from .env at root

* fix definitions

---------

Co-authored-by: tarashagarwal <[email protected]>
Co-authored-by: Dev Singh <[email protected]>
@devksingh4
Prepare basic UI tests in the pipeline (#30)
c38551c 
* add basic ui tests

* fix lint

* setup ui tests to be run in our pipeline

* fix health check to run both UI and API

* fix clean command

* fix editorconfig

* fix pipelines to reuse environments and ensure consistency

* fix name

* fix name

* Fix some values
@devksingh4
update README
75a086d
@devksingh4
IAM Group Management updates (#32)
4316175 
* update logging

* prevent adding non-paid members to groups which require paid membership

* fix linting

* fix lint

* fix lockfile

* ui: use correct group in correct environment, and fix error notifications for partial errors

* add gpt-generated tests for the group management panel

* add health check to pipeline
@devksingh4
Add basic playwright tests (#33)
42c801d 
* add basic playwright tests

* fix playwright env check for AWS credentials

* fix env prioritization

* add loading overlay; fix playwright install

* fix test stage names
@devksingh4
Update tests (#34)
85b585f 
* reorder the e2e tests directory

* fix linting/formatting

* add data-testid to events table

* add a basic upcoming events view test

* update

* fix pre-commit

* Revert "fix pre-commit"

This reverts commit 1997364.
@devksingh4
fix workflow
061f12d
@devksingh4
Add build revision and copyright to the UI (#35)
4177754 
* add build revision to appshell

* fix README

* fix revision on mobile
@devksingh4
update license
54a5804
devksingh4 and others added 18 commits February 6, 2025 19:05
@devksingh4
fix the request username
3164efd
@devksingh4
change name of label
2c550a8
@devksingh4
update infra chair group ID
2781411
@devksingh4
stripe: add viewing current links
266c04b
@devksingh4
update log statement
ccea44b
@devksingh4
cleanup imports
764882c
@devksingh4
update unit tests
a6ab6de
@devksingh4
fix stripe integration tests (#51)
1a83fa3 
* fix stripe API unit tests

* add a basic stripe e2e test

* fix types

* fix UI error throwing
@devksingh4
enable the core.acm.illinois.edu domain
f729b90
@devksingh4
add a lock around auth checking for AuthGuard
9ad9ec8
@devksingh4
fix early return in api route
a57cbfc
@devksingh4
add unique key to render
cf06307
@devksingh4
fix locking mechanism for cached responses
095f933
@devksingh4
add more loading skeletons to UI
7b3d116
@devksingh4
change default name transformation
aaba705
@devksingh4
enable modifying multiple groups
06336ea
@devksingh4
cleanup jwtgen scripts
920f71d
@devksingh4
fix e2e tests
f727980 
the new name normalizer changed the avatar
@EthM370
Copy link
Author

EthM370 commented Feb 13, 2025

image
@devksingh4 Is this model a general idea of what you envision for a RESTful API approach to creating a normal event vs paid event?

@devksingh4
Copy link
Member

@EthM370 yes - but don't forget you have to also create the stripe product, etc.

@EthM370
Copy link
Author

EthM370 commented Feb 14, 2025

@devksingh4 I made a push of a general implementation of paidEvent as a specific type of event resource, please look over and give advice? Users can now select if they want a paidticket/paidmerch event which reveals additional input textboxes. When users click submit, it send the entire form (basic event information + paid information) to event.ts, which splits and adds both an event in EventTable and an according ticket/merch event in corresponding metadata.

@EthM370 EthM370 requested a review from devksingh4 February 14, 2025 18:10
@devksingh4
Copy link
Member

@jlevine18 can I get you to take a look?

@devksingh4
Copy link
Member

devksingh4 commented Feb 14, 2025 •
edited
Loading

@EthM370 there seems to be wayy too many files changed - what happened in the merge from master? Maybe you can copy just your changes into a new branch? I can't possibly review this many changes - I think there's some merge issue.

EDIT: I think i can fix this let me try

@devksingh4 devksingh4 force-pushed the EthM370/paideventRoutes branch from 8f2524d to 83168dc Compare February 14, 2025 21:20
@EthM370 EthM370 closed this Feb 14, 2025
@EthM370 EthM370 deleted the EthM370/paideventRoutes branch February 14, 2025 22:53
@github-actions github-actions bot temporarily deployed to management-ui-prod (Production) February 15, 2025 21:11 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarashagarwal tarashagarwal Awaiting requested review from tarashagarwal

@devksingh4 devksingh4 Awaiting requested review from devksingh4

Assignees

@EthM370 EthM370

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthM370 @devksingh4 @tarashagarwal