Changes related to accommodate nightwatch tests in Gitlab CI #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 4, 2024 19:11
secretsayan
added
enhancement
secretsayan
force-pushed
the
wip
branch
2 times, most recently
from
792b3e7 to
ab0e9b4
Compare
TravisCarden
approved these changes
Jan 9, 2024
added 2 commits
January 17, 2024 14:38
added 3 commits
January 18, 2024 00:11
|
@TravisCarden Requesting one more round of review on this ASAP. |
TravisCarden
approved these changes
Jan 19, 2024
secretsayan
pushed a commit
to secretsayan/orca
that referenced
this pull request
Feb 15, 2024
) * tests * tests * tests * tests * tests * tests * go to 4444 * remove core nightwatch * enable core tests and disable shm * remove core tests * change port * remoce chromedriver * use port 9515 for gitlab * minor fix * Ignore toolbar from nightwatch * cleanup * comments * comments * comments * Gitlab CI * add junit log for all phpunit tests * minor changes * minor changes 2 * Cleanup * change port for gitlab ci * remove chromedriver * change port * change port 2 * Add cobertura format instead of clover * Apply suggestions from code review --------- Co-authored-by: Travis Carden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three changes -
separate containerlikedrupal.orgtemplates.Coberturaformat instead ofClover. Other changes related to names of variable fromclovertocoberturawill be handled in Change coverage clover to cobertura for Gitlab CI #484 and not here due to time constraints.junitlog for all thephpunittests so that all tests and reports are shown in the Tests tab of Gitlab CI.