Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation unification #169

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Propagation unification #169

wants to merge 6 commits into from

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Feb 11, 2025

Generalize propagation logic to reuse in the propagation actions and create a generic propagation action that unifies all the propagation actions into one.

Copy link

github-actions bot commented Feb 11, 2025

Unit Test Results (build & test)

111 tests  +7   111 ✅ +7   16s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f954357. ± Comparison against base commit 1d304b0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 77.83094% with 139 lines in your changes missing coverage. Please review.

Project coverage is 57.09%. Comparing base (1d304b0) to head (f954357).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tion/logical_dataset/logical_dataset_propagator.py 0.00% 47 Missing ⚠️
.../plugin/action/propagation/docs/docs_propagator.py 71.54% 35 Missing ⚠️
...ub_actions/plugin/action/propagation/propagator.py 81.33% 14 Missing ⚠️
...n/action/propagation/generic_propagation_action.py 87.85% 13 Missing ⚠️
...opagation/propagation_strategy/lineage_strategy.py 88.09% 10 Missing ⚠️
...atahub_actions/plugin/action/tag/tag_propagator.py 86.88% 8 Missing ⚠️
...ub-actions/src/datahub_actions/api/action_graph.py 25.00% 3 Missing ⚠️
...ugin/action/propagation/docs/propagation_action.py 0.00% 3 Missing ⚠️
...ons/plugin/action/propagation/propagation_utils.py 84.21% 3 Missing ⚠️
.../propagation/propagation_strategy/base_strategy.py 88.88% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
Files with missing lines Coverage Δ
...ons/src/datahub_actions/plugin/action/mcl_utils.py 100.00% <100.00%> (+100.00%) ⬆️
...ugin/action/propagation/propagation_rule_config.py 100.00% <100.00%> (ø)
...opagation/propagation_strategy/sibling_strategy.py 100.00% <100.00%> (ø)
...ons/src/datahub_actions/plugin/action/mce_utils.py 96.77% <96.77%> (ø)
.../propagation/propagation_strategy/base_strategy.py 88.88% <88.88%> (ø)
...ub-actions/src/datahub_actions/api/action_graph.py 16.47% <25.00%> (-0.19%) ⬇️
...ugin/action/propagation/docs/propagation_action.py 15.82% <0.00%> (+15.82%) ⬆️
...ons/plugin/action/propagation/propagation_utils.py 87.80% <84.21%> (+87.80%) ⬆️
...atahub_actions/plugin/action/tag/tag_propagator.py 86.88% <86.88%> (ø)
...opagation/propagation_strategy/lineage_strategy.py 88.09% <88.09%> (ø)
... and 4 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d304b0...f954357. Read the comment docs.

@treff7es treff7es force-pushed the propagation_unification branch from 4695d1e to 0afbf4c Compare February 12, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant