Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in input description #221

Closed
wants to merge 3 commits into from
Closed

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Mar 28, 2025

This change (#168) is a wonderful improvement. This patch simply fixes a trivial typo.
The typo occurred due to a file included in @octokit/openapi 18.0.0. Since the typo is fixed in 18.2.0, this patch upgrades the version.

@Yang-33 Yang-33 requested a review from a team as a code owner March 28, 2025 14:49
@parkerbxyz
Copy link
Contributor

Thanks, @Yang-33! Great catch. I noticed the same typo when we implemented #168 and fixed it upstream. We just needed to wait for an update @octokit/openapi for the changes to come through so the fix in this repo didn't get overwritten by the auto-update script.

We're now using a workflow to auto-update the permission inputs anytime there is a relevant update in the OpenAPI spec. This happened in #225, resulting in the head branch of this pull request being even with the base branch. Since there are no longer any changes to merge, I'll go ahead and close this pull request.

@parkerbxyz parkerbxyz closed this Apr 3, 2025
@Yang-33 Yang-33 deleted the fix-typo branch April 4, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants