Read version from use-node-version key of .npmrc #1149
+640
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aparnajyothi-y for visibility |
|
@aparnajyothi-y , gentle bump on this :) |
|
We would love to be able to drop |
greyaxie
approved these changes
Nov 8, 2024
|
@aparnajyothi-y, bumping this again :) I'd love to get this in if my changes look good to you |
|
[Copilot is generating a summary...] Marge comment |
|
@aparnajyothi-y, seems like you're quite busy. Is there someone else I should be seeking a review from? |
|
I'd love to see this too! @aparnajyothi-y or @priya-kinthali, any chance we can nudge you to review this PR? |
kyle-leonhard
approved these changes
Feb 5, 2025
| @@ -56,6 +57,25 @@ export function getNodeVersionFromFile(versionFilePath: string): string | null { | |||
| core.info('Node version file is not JSON file'); | |||
| } | |||
|
|
|||
| // Try parsing the file as an NPM `.npmrc` file. | |||
| // | |||
| // If the file contents contain the use-node-version key, we conclude it's an | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for determining the Node version from the
use-node-versionkey of.npmrcas described in the PNPM docs.Related issue:
Resolves #1130
Check list: